Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV2-6140: replicating status to children #2209

Merged
merged 1 commit into from
Feb 10, 2025
Merged

CV2-6140: replicating status to children #2209

merged 1 commit into from
Feb 10, 2025

Conversation

melsawy
Copy link
Contributor

@melsawy melsawy commented Feb 10, 2025 •
edited
Loading

Description

Bypass the check for published items when replicating status to children.

References: CV2-6140

How has this been tested?

Re-run automated tests.

Things to pay attention to during code review

Checklist

  • I have performed a self-review of my own code
  • I have added unit and feature tests, if the PR implements a new feature or otherwise would benefit from additional testing
  • I have added regression tests, if the PR fixes a bug
  • I have added logging, exception reporting, and custom tracing with any additional information required for debugging
  • I considered secure coding practices when writing this code. Any security concerns are noted above.
  • I have commented my code in hard-to-understand areas, if any
  • I have made needed changes to the README
  • My changes generate no new warnings
  • If I added a third party module, I included a rationale for doing so and followed our current guidelines

@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 10, 2025

Code Climate has analyzed commit 6cab8e4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@melsawy melsawy merged commit cdb68cd into develop Feb 10, 2025
15 of 16 checks passed
@melsawy melsawy deleted the CV2-6140-side-kiq-dead-jobs-active-record-record-invalid branch February 10, 2025 13:41
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 10, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RuntimeError: {"message":"Desculpe, você não pode alterar o status durante a publicação do relatório","code":12... Sidekiq/Sidekiq::Extensions::DelayedClass View Issue

Did you find this useful? React with a 👍 or 👎

melsawy added a commit that referenced this pull request Feb 10, 2025
@melsawy
CV2-6140: skip published check for status (#2209)
0ec8e15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjay-w jayjay-w jayjay-w approved these changes

@caiosba caiosba Awaiting requested review from caiosba caiosba is a code owner

@vasconsaurus vasconsaurus Awaiting requested review from vasconsaurus vasconsaurus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melsawy @jayjay-w